-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies to setup.py for Pip install #357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 88.59% 88.55% -0.04%
==========================================
Files 19 19
Lines 1490 1546 +56
Branches 204 187 -17
==========================================
+ Hits 1320 1369 +49
- Misses 137 143 +6
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
Tested successfully in a venv on Arch Linux with Python 3.10 |
Based on working with my pyinstaller static builds and some recent changes to a few of the dependencies, here is my recommendation, which has been tested on Windows.
|
I would be very happy to be able to install CQ-Editor and its correct dependencies with pip. I am on Ubuntu Linux |
@sethfischer I rebased this on master and tried to install using It installs, but when I try to run cq-editor, I am getting:
|
Solved by: |
a061e63
to
acbe221
Compare
What's the state of this? This seems like a good change |
This package can be pip installed now although it is new and there may be issues.
Or you can install the latest master via pip/git. |
Tested on Ubuntu 20.04 with Python 3.9.
Pip
Poetry
Experimental.
Closes #352